[2.7] bpo-36147: Fix a variable going out of scope.#12102
Merged
vstinner merged 1 commit intopython:2.7from Mar 6, 2019
Merged
[2.7] bpo-36147: Fix a variable going out of scope.#12102vstinner merged 1 commit intopython:2.7from
vstinner merged 1 commit intopython:2.7from
Conversation
The s_get function leaks the result variable. Partially backport commit 19b5254 to fix it.
vstinner
approved these changes
Mar 4, 2019
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, that's a copy of the code used in the master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The s_get function leaks the result variable.
Partially backport commit 19b5254
to fix it.
https://bugs.python.org/issue36147